From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC v2 qemu/storage 00/10] storage plugin method to get qemu blockdevice options for volume
Date: Tue, 3 Jun 2025 10:02:14 +0200 [thread overview]
Message-ID: <4c533ea6-0826-4432-b21f-d2cdb6462d39@proxmox.com> (raw)
In-Reply-To: <mailman.183.1748881484.395.pve-devel@lists.proxmox.com>
Am 02.06.25 um 18:24 schrieb DERUMIER, Alexandre via pve-devel:
>>>
>>> * Drop $snapshot parameter, currently there is no need to attach
>>> snapshots via -blockdev. They would need to be attached read-only
>>> too to not fail and this can always be added later.
>
>
>>> I need it in different places in the external snapshot code (to
>>> generate the backing chain, in the snapshot creation to rettach
>>> renamed
>>> snapshot volname,...)
>
> Ah, sorry, I didn't have see the $options->{'snapshot-name'}.
Initially, I dropped it, but added it back via $options before sending
v2. Sorry about the confusion/wrong changelog entry.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-06-03 8:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 13:31 Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 qemu 01/10] block/rbd: support selected key-value-pairs via QAPI Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 qemu 02/10] block/rbd: support keyring option " Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 03/10] plugin: add method to get qemu blockdevice options for volume Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 04/10] iscsi direct plugin: implement method to get qemu blockdevice options Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 05/10] zfs iscsi plugin: implement new " Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 06/10] zfs pool plugin: implement " Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 07/10] rbd plugin: implement new " Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 08/10] plugin: qemu block device: add hints option and EFI disk hint Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 09/10] plugin: qemu block device: add support for snapshot option Fiona Ebner
2025-05-23 13:31 ` [pve-devel] [RFC v2 storage 10/10] plugin api: bump api version and age Fiona Ebner
2025-06-02 16:12 ` [pve-devel] [RFC v2 qemu/storage 00/10] storage plugin method to get qemu blockdevice options for volume DERUMIER, Alexandre via pve-devel
[not found] ` <9d08a1aab040d04a6f3096dfd1b3dabd30fa9315.camel@groupe-cyllene.com>
2025-06-02 16:24 ` DERUMIER, Alexandre via pve-devel
2025-06-03 8:02 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c533ea6-0826-4432-b21f-d2cdb6462d39@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal