From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Rusovac <d.rusovac@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/1] fix #7149: ui: prohibit realm update on login
Date: Wed, 28 Jan 2026 08:44:41 +0100 [thread overview]
Message-ID: <4c4ea29c-9f12-4801-8b87-69966d901679@proxmox.com> (raw)
In-Reply-To: <6a990c3a-32c6-4caa-90b3-3fdd3e645e99@proxmox.com>
On 1/27/26 7:46 PM, Thomas Lamprecht wrote:
>
> Anyhow, should have been caught on review, so no fault from your
> side, but please try to keep this somewhat in mind for future
> commits/patches.
>
Hi,
wanted to say sorry for that.
I can't really say what my thoughts were at the time of the review, but
I probably did not pay enough attention to the commit subject/message.
Will do better in the future!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-28 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 12:42 [pve-devel] [PATCH manager/proxmox-backup 0/2] " Dominik Rusovac
2025-12-18 12:42 ` [pve-devel] [PATCH proxmox-backup 1/1] " Dominik Rusovac
2025-12-18 12:42 ` [pve-devel] [PATCH pve-manager " Dominik Rusovac
2026-01-27 18:47 ` Thomas Lamprecht
2026-01-28 6:52 ` Dominik Rusovac
2026-01-28 7:44 ` Dominik Csapak [this message]
2025-12-19 8:23 ` [pve-devel] [PATCH manager/proxmox-backup 0/2] " Dominik Csapak
2026-01-13 10:27 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c4ea29c-9f12-4801-8b87-69966d901679@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox