* [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface.
@ 2020-11-26 9:18 Alexandre Derumier
2020-11-27 14:27 ` [pve-devel] applied: " Thomas Lamprecht
2020-11-27 14:33 ` [pve-devel] " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Derumier @ 2020-11-26 9:18 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
src/PVE/INotify.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index 676dcc6..54f4031 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -1557,6 +1557,8 @@ sub __write_etc_network_interfaces {
$p = $1;
$vlanid = $2;
delete $d->{'vlan-raw-device'} if $d->{'vlan-raw-device'};
+ delete $d->{'vlan-id'} if $d->{'vlan-id'};
+
} else {
die "missing vlan-raw-device option" if !$d->{'vlan-raw-device'};
$p = $d->{'vlan-raw-device'};
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [pve-devel] applied: [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface.
2020-11-26 9:18 [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface Alexandre Derumier
@ 2020-11-27 14:27 ` Thomas Lamprecht
2020-11-27 14:33 ` [pve-devel] " Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-27 14:27 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexandre Derumier
On 26.11.20 10:18, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> src/PVE/INotify.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface.
2020-11-26 9:18 [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface Alexandre Derumier
2020-11-27 14:27 ` [pve-devel] applied: " Thomas Lamprecht
@ 2020-11-27 14:33 ` Thomas Lamprecht
2020-11-27 17:49 ` alexandre derumier
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-27 14:33 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexandre Derumier
we probably also want to hide the "Vlan raw device" and "VLAN Tag" field in the
web interface for such interfaces (and unify the VLAN casing while we're at ^^)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface.
2020-11-27 14:33 ` [pve-devel] " Thomas Lamprecht
@ 2020-11-27 17:49 ` alexandre derumier
0 siblings, 0 replies; 4+ messages in thread
From: alexandre derumier @ 2020-11-27 17:49 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion
On 27/11/2020 15:33, Thomas Lamprecht wrote:
> we probably also want to hide the "Vlan raw device" and "VLAN Tag" field in the
> web interface for such interfaces (and unify the VLAN casing while we're at ^^)
>
yes, indeed.
we have 3 differents cases:
ethx.y (no option)
vlanY (vlan-raw-device)
randomname (vlan-raw-device + vlan-id, ifupdown2 only)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-27 17:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 9:18 [pve-devel] [PATCH pve-common] Inotify: delete vlan-id for "iface.X" vlan iface Alexandre Derumier
2020-11-27 14:27 ` [pve-devel] applied: " Thomas Lamprecht
2020-11-27 14:33 ` [pve-devel] " Thomas Lamprecht
2020-11-27 17:49 ` alexandre derumier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox