From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH common] tools: file_set_contents: use syswrite instead of print
Date: Wed, 25 Sep 2024 16:37:47 +0200 [thread overview]
Message-ID: <4c0d4b92-356d-4160-bef1-957e2edf32db@proxmox.com> (raw)
In-Reply-To: <20240924143321.93696-1-f.schauer@proxmox.com>
hi,
as we already talked off list, this may be an issue when we do have a string
that is marked as utf8 (e.g. api parameters that contain codepoints > 127)
if such a parameter reach the syswrite it will fail, so we should probably
use is_utf8 (or something better?) to detect if a string is utf8 and encode
it before passing it to syswrite.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-25 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 14:33 Filip Schauer
2024-09-25 8:39 ` Dietmar Maurer
2024-09-25 12:54 ` Filip Schauer
2024-09-25 14:37 ` Dominik Csapak [this message]
2024-09-30 11:38 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c0d4b92-356d-4160-bef1-957e2edf32db@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox