From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage 09/10] common: introduce common module
Date: Wed, 18 Dec 2024 10:41:56 +0100 [thread overview]
Message-ID: <4bcbf375-5fcd-47b3-90ee-95fb1555daaf@proxmox.com> (raw)
In-Reply-To: <D6EQ3GRJNK3Q.3FN6IF1I4D5WL@proxmox.com>
Am 18.12.24 um 10:36 schrieb Max Carrara:
> On Tue Dec 17, 2024 at 4:48 PM CET, Fiona Ebner wrote:
>> From: Max Carrara <m.carrara@proxmox.com>
>>
>> This module's purpose is to provide shared functions, constants, etc.
>> for storage plugins and storage-related operations.
>>
>> It also contains the `get_deprecation_warning` subroutine that makes
>> it easier to warn developers and/or plugin authors that a subroutine
>> will be removed in the future.
>
> Thanks for including this patch already! Was really happy to see this :)
>
> Since I've never included a commit from somebody else's series / RFC in
> another series, is the commit message usually left as it is? You did
> mention below that you start out with a different function for your use
> case, but wouldn't it make sense to adapt the commit message overall
> accordingly? In this case, just the paragraph above my reply here.
>
Yes, the commit message should be adapted here. Thank you for pointing
this out!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-18 9:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:48 [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 01/10] iscsi direct plugin: fix return value for path() method in non-array context Fiona Ebner
2024-12-18 13:39 ` Fiona Ebner
2024-12-18 13:43 ` Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 02/10] rbd plugin: schema: document default value for 'krbd' setting Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 03/10] export: redirect stdout to avoid any unrelated messages ending up in the export stream Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 04/10] rbd plugin: factor out helper to check if volume already exists Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export Fiona Ebner
2024-12-18 14:20 ` Daniel Kral
2024-12-18 15:14 ` Fiona Ebner
2024-12-18 15:33 ` DERUMIER, Alexandre via pve-devel
2024-12-19 8:56 ` Fiona Ebner
2024-12-19 10:43 ` DERUMIER, Alexandre via pve-devel
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 06/10] iscsi plugin: support volume export Fiona Ebner
2024-12-18 14:05 ` Filip Schauer
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 07/10] iscsi direct " Fiona Ebner
2024-12-18 14:07 ` Filip Schauer
2024-12-17 15:48 ` [pve-devel] [RFC v2 storage 08/10] rbd plugin: volume exists helper: distinguish between different errors Fiona Ebner
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 09/10] common: introduce common module Fiona Ebner
2024-12-18 9:36 ` Max Carrara
2024-12-18 9:41 ` Fiona Ebner [this message]
2024-12-17 15:48 ` [pve-devel] [PATCH v2 storage 10/10] plugins: volume import: align size up to 1KiB Fiona Ebner
2024-12-18 10:34 ` [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages Fiona Ebner
2024-12-18 14:08 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bcbf375-5fcd-47b3-90ee-95fb1555daaf@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox