From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: [pve-devel] applied: [qemu-server] fix: do not allow live-migration with clipboard=vnc
Date: Wed, 29 Nov 2023 10:31:35 +0100 [thread overview]
Message-ID: <4b98def2-25a9-4a59-8a5e-66095071a4d8@proxmox.com> (raw)
In-Reply-To: <20231124123238.169891-1-m.frank@proxmox.com>
Am 24.11.23 um 13:32 schrieb Markus Frank:
> In the migrate_vm_precondition API function if clipboard
> is set to vnc on a running VM the text "clipboard=vnc"
> gets added to local_resources so that the GUI blocks execution and shows:
> "Can't migrate VM with local resources: clipboard=vnc"
>
> In QemuMigrate's prepare function a new 'die' prevents a
> live-migration if a running VMs has clipboard set to vnc.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
applied, thanks!
Added the reason why to the commit message (because QEMU's vdagent
device doesn't support it yet) and reworded it a bit to avoid talking
about code specifics and (hopefully) improve readability.
Also made a follow-up adding this information to the description of the
clipboard in the schema. When it's added to the UI, it would also be
great to have a hint there, because it is rather surprising that it
prevents live-migration.
prev parent reply other threads:[~2023-11-29 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 12:32 [pve-devel] " Markus Frank
2023-11-29 9:31 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b98def2-25a9-4a59-8a5e-66095071a4d8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox