From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9
Date: Tue, 11 Feb 2025 10:45:56 +0100 [thread overview]
Message-ID: <4b5d25c0-4dde-41fa-8fa4-40a8d49af3b8@proxmox.com> (raw)
In-Reply-To: <0b44771a-6592-4684-ae41-8cb9639156fd@proxmox.com>
Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/LXC/Migrate.pm | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>>
>
> applied, thanks!
>
> The first patch was already applied by Fabian on 2024-12-19:
>
> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9
Fabian told me (off-list, well...) that it's still useful as an early
check and that makes sense. I guess it can be improved by querying the
transport formats for all disks early via the storage layer proper, but
the check should not be dropped completely. And IIRC, VM migration is
currently missing such an early check.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-11 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 10:32 [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Fiona Ebner
2024-12-18 10:32 ` [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9 Fiona Ebner
2025-02-10 16:12 ` [pve-devel] applied: " Thomas Lamprecht
2025-02-11 9:45 ` Fiona Ebner [this message]
2025-02-11 9:51 ` Thomas Lamprecht
2024-12-18 14:21 ` [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5d25c0-4dde-41fa-8fa4-40a8d49af3b8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal