From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG
Date: Mon, 24 Jul 2023 10:25:16 +0200 [thread overview]
Message-ID: <4aefac1e-339c-0679-6fd8-7f3a91071a91@proxmox.com> (raw)
In-Reply-To: <313fdf75-38dd-492d-8588-77fa445a7415@proxmox.com>
On 7/21/23 16:04, Thomas Lamprecht wrote:
> well we could also meed in the middle, if having 32, 34 or 36 px is
> enough to make it "less cramped"?
Yeah, the main reason for 38px was the consistency to other products.
Now that I play around a bit with different heights, I feel like the
major visual improvement (I know, this is subjective) comes from
the added horizontal padding between the logo and the product name (5px),
as well as the centered search. I'd be happy to settle on 30px it that
makes it any easier to sell the centered, larger search box. ;)
--
- Lukas
prev parent reply other threads:[~2023-07-24 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:39 Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText Lukas Wagner
2023-07-21 13:31 ` Thomas Lamprecht
2023-07-21 14:04 ` Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser Lukas Wagner
2023-07-21 13:54 ` Thomas Lamprecht
2023-07-21 14:54 ` Lukas Wagner
2023-07-21 14:04 ` [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Thomas Lamprecht
2023-07-24 8:25 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aefac1e-339c-0679-6fd8-7f3a91071a91@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox