public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Tim Marx <t.marx@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v1] chore: update `compileSdkVersion` to 35 and `targetSdkVersion` to 36
Date: Fri, 4 Jul 2025 10:53:52 +0200	[thread overview]
Message-ID: <4ad500da-d5bc-40d8-9d76-d6b71d4b7a5d@proxmox.com> (raw)
In-Reply-To: <1893456957.1437.1751555908572@webmail.proxmox.com>

Am 03.07.25 um 17:18 schrieb Tim Marx:
> I think you are misinterpreting that Thomas, I meant what I said before.
> 
> The post Dominik referenced is right here, it definitely says that you should not have a higher targetSdkVersion, that is due the the Gradle build process and how they determine runtime compatibility for release builds and debug builds.
> https://medium.com/androiddevelopers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd
> 
> In the comments it is iterated again:
> https://medium.com/@ianhlake/libraries-that-you-are-including-as-aars-or-remote-dependencies-from-maven-repositories-are-ca6cd7dd96ec
> 
> It does not make sense to me to have a higher target, you can't test that if you compile against a lower SDK.


Yeah, I rechecked I was indeed misinterpreting this and found some confirmation
bias on (confused) answers online like stack overflow, thanks to you and
Dominik for clearing this up!

One thing that annoys me a bit is though that per the Link from Shan it
really states very explicitly in the official docs:

> The value of `targetSdk` must be less than or equal to that of `compileSdk`.

So breaking this should really result in a build error...

But anyway, @Shan, let's upgrade biometrics storage instead, maybe there's a new
version already, or alternatively ugprade it ourselves (and also sent that patch
upstream). FWIW, we had already a downstream version using a path dependency  of
that library in the past for an important bug fix, so doing this would be the
first time.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-04  8:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  9:10 Shan Shaji
2025-07-03 14:03 ` Dominik Csapak
2025-07-03 14:20   ` Tim Marx
2025-07-03 14:28     ` Thomas Lamprecht
2025-07-03 14:25   ` Thomas Lamprecht
2025-07-03 14:45     ` Dominik Csapak
2025-07-03 14:56       ` Thomas Lamprecht
2025-07-03 15:18         ` Tim Marx
2025-07-04  6:52           ` Shan Shaji
2025-07-04  8:53           ` Thomas Lamprecht [this message]
2025-07-04 11:15             ` Shan Shaji
2025-07-07  9:51               ` Shan Shaji
2025-07-03 14:36 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ad500da-d5bc-40d8-9d76-d6b71d4b7a5d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    --cc=t.marx@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal