From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v7 0/1] fix #4957: add vendor and product information passthrough for SCSI-Disks
Date: Fri, 26 Jan 2024 11:19:34 +0100 [thread overview]
Message-ID: <4abb3860-dc51-4a14-9f78-d64dc1ac6d09@proxmox.com> (raw)
In-Reply-To: <20240110124549.160682-1-h.duerr@proxmox.com>
Am 10.01.24 um 13:45 schrieb Hannes Duerr:
> qemu-server:
>
> Hannes Duerr (1):
> fix #4957: add vendor and product information passthrough for
> SCSI-Disks
>
> PVE/API2/Qemu.pm | 39 +++++++++++++++++++++++++++++++++++++++
> PVE/QemuServer.pm | 12 ++++++++++++
> PVE/QemuServer/Drive.pm | 24 ++++++++++++++++++++++++
> 3 files changed, 75 insertions(+)
>
>
> Summary over all repositories:
> 3 files changed, 75 insertions(+), 0 deletions(-)
>
applied, thanks!
Squashed in a few style changes that didn't warrant a new version IMHO:
- You can use up to 100 characters per line, no need to split function
calls early, if they can fit that limit
- The exception message should be for raised for the config option, not
the sub-option, e.g. 'scsi0' instead of 'product'
- Also fixed the style for the exception (missing trailing comma,
indentation, message missing a space):
> - product => "Passing of product information is only supported for".
> - "'scsi-hd' and 'scsi-cd' devices (e.g. not pass-through)."
> + $opt => "Passing of product information is only supported for 'scsi-hd' and "
> + ."'scsi-cd' devices (e.g. not pass-through).",
prev parent reply other threads:[~2024-01-26 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 12:45 [pve-devel] " Hannes Duerr
2024-01-10 12:45 ` [pve-devel] [PATCH qemu-server v7 1/1] " Hannes Duerr
2024-01-26 10:19 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4abb3860-dc51-4a14-9f78-d64dc1ac6d09@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox