From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v3 3/3] fix #3258: block vm start when pci device is already in use
Date: Fri, 15 Oct 2021 19:59:45 +0200 [thread overview]
Message-ID: <4aaa2439-8aa7-25e5-9a9c-384c96b7ce16@proxmox.com> (raw)
In-Reply-To: <20211007134531.1693674-4-d.csapak@proxmox.com>
On 07.10.21 15:45, Dominik Csapak wrote:
> on vm start, we reserve all pciids that we use, and
> remove the reservation again in vm_stop_cleanup
>
> first with only a time-based reservation but after the vm is started,
> we reserve again but with the pid.
>
> for this, we have to move the start_timeout calculation above the
> hostpci handling.
>
> also moved the pci initialization out of the conf parsing loop
> so that we can reserve all ids before we actually touch any of them
>
> while touching the lines, fix the indentation
>
> this way, when a vm starts with a pci device that is already configured
> for a different running vm, will not be started and the user gets
> the error that the device is already in use
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/QemuServer.pm | 50 +++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 42 insertions(+), 8 deletions(-)
>
>
applied but had to resolve a merge conflict which, thanks!
prev parent reply other threads:[~2021-10-15 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 13:45 [pve-devel] [PATCH qemu-server v3 0/3] fix #3258: check for in-use pci devices on vm start Dominik Csapak
2021-10-07 13:45 ` [pve-devel] [PATCH qemu-server v3 1/3] pci: refactor pci device preparation Dominik Csapak
2021-10-11 6:49 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-07 13:45 ` [pve-devel] [PATCH qemu-server v3 2/3] pci: add helpers to (un)reserve pciids for a vm Dominik Csapak
2021-10-15 17:59 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-07 13:45 ` [pve-devel] [PATCH qemu-server v3 3/3] fix #3258: block vm start when pci device is already in use Dominik Csapak
2021-10-15 17:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aaa2439-8aa7-25e5-9a9c-384c96b7ce16@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox