Re: [pve-devel] [RFC ha-manager v3 15/15] manager: persistently migrate ha groups to ha rules

From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [RFC ha-manager v3 15/15] manager: persistently migrate ha groups to ha rules
Date: Tue, 22 Jul 2025 18:56:52 +0200	[thread overview]
Message-ID: <4aa8d0ce-88a7-41d1-8ba3-4297363840a1@proxmox.com> (raw)
In-Reply-To: <bfcad994-aa6e-4d3f-82ea-c902689ab3a5@proxmox.com>

On 7/22/25 18:38, Michael Köppl wrote:
> This results in the following error:
> 	Abort HA group migration: failed to remove group config: No such file
> or directory
> 
> The value in $ha_groups_config is only part of the path to the
> groups.cfg file. It works for the remaining functions here because the
> cfs_write_file() and cfs_read_file() functions append prepend "/etc/pve/".
> 
> Could be fixed by:
>     my $group_config_file = "/etc/pve/" . $ha_groups_config;
> 
>     unlink $group_config_file or die "failed to remove group config: $!\n";
> 
> or something similar.
> 

> This throws an error, stopping the migration since it depends on all
> nodes having the correct version, because the value in
> $version_info->{$node} is a string. Could be fixed by:
> 
>     my $node_version_info = eval { decode_json($version_info->{$node}) };
>     return $node_version_info->{version};
> 
>> +}
>> +

Sent follow-up patches with fixes for these:
https://lore.proxmox.com/pve-devel/20250722165428.90281-1-m.koeppl@proxmox.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel