* [pve-devel] applied: [PATCH v3 container] fix #2820: don't hotplug over existing mpX [not found] <20200702101023.237367-1-o.bektas@proxmox.com> @ 2020-07-13 11:00 ` Thomas Lamprecht 2020-07-13 11:16 ` Oguz Bektas 0 siblings, 1 reply; 2+ messages in thread From: Thomas Lamprecht @ 2020-07-13 11:00 UTC (permalink / raw) To: PVE development discussion, Oguz Bektas On 02.07.20 12:10, Oguz Bektas wrote: > check if the given mpX already exists in the config. if it does, then > skip hotplugging and write the changes to [pve:pending] for the next > reboot of CT. > > after rebooting the CT, the preexisting mpX will be added as unused and > the mpX will be mounted. > > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com> > --- > src/PVE/LXC/Config.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > applied, thanks! Maybe we want the GUI "Add MP" to avoid pre selecting a MP id which is pending deletions? At least if others are still free? ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] applied: [PATCH v3 container] fix #2820: don't hotplug over existing mpX 2020-07-13 11:00 ` [pve-devel] applied: [PATCH v3 container] fix #2820: don't hotplug over existing mpX Thomas Lamprecht @ 2020-07-13 11:16 ` Oguz Bektas 0 siblings, 0 replies; 2+ messages in thread From: Oguz Bektas @ 2020-07-13 11:16 UTC (permalink / raw) To: Thomas Lamprecht; +Cc: PVE development discussion On Mon, Jul 13, 2020 at 01:00:55PM +0200, Thomas Lamprecht wrote: > On 02.07.20 12:10, Oguz Bektas wrote: > > check if the given mpX already exists in the config. if it does, then > > skip hotplugging and write the changes to [pve:pending] for the next > > reboot of CT. > > > > after rebooting the CT, the preexisting mpX will be added as unused and > > the mpX will be mounted. > > > > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com> > > --- > > src/PVE/LXC/Config.pm | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > > > applied, thanks! Maybe we want the GUI "Add MP" to avoid pre selecting a MP id > which is pending deletions? At least if others are still free? yes, makes sense. i'll look into that ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-13 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200702101023.237367-1-o.bektas@proxmox.com>
2020-07-13 11:00 ` [pve-devel] applied: [PATCH v3 container] fix #2820: don't hotplug over existing mpX Thomas Lamprecht
2020-07-13 11:16 ` Oguz Bektas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox