From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] patrially-applied-series: [PATCH-SERIES v3 manager] split up content view into a view for each type
Date: Mon, 16 Nov 2020 10:11:17 +0100 [thread overview]
Message-ID: <4a864113-e8a2-78c6-e2a3-81ceaf2f11d6@proxmox.com> (raw)
In-Reply-To: <20201113131633.21915-1-f.ebner@proxmox.com>
On 13.11.20 14:16, Fabian Ebner wrote:
> The goal of doing this is to have more flexibility/cleaner code for
> content-type-dependent features in the content view. Now only buttons
> that are useful for each content type are displayed. And it might make
> sense to display different columns for different content types, e.g.
> 'parent' for cloned VM/CT images. (see #16)
>
> API calls might be faster if only one type of content is requested.
> The obvious drawback is that there is no view with all contents anymore.
>
> The first patch is not directly related. It fixes the extension filters
> when selecting a file to upload.
>
> The last four patches are not directly related, but introduce grouping of backups
> and introduce the prune window, which was essentially copied from the PBS code.
>
> The prune window patch depends on this patch (otherwise it would error
> out when all numberfields are cleared):
> https://lists.proxmox.com/pipermail/pve-devel/2020-November/045916.html
>
> Changes from v2:
> * rebase on current master and deal with the new comment column
> * fix backup grouping for PBS storages
> * base prune window on the current prune window from PBS (there were
> some changes in the time since I sent v2)
>
> Fabian Ebner (20):
> fix extension filter for upload window
> config panel: allow new nodes to be added later
> storage panel/browser: use insertNodes function
> add CD ROM and lxc icons for treelist-item-icon
> use separate view for each content type
> remove the now unnecessary grouping by content type
> remove the now unneccessary content type column
> content view: allow specifying title bar elements for init
> turn {nodename,storage,sm} into object variables
> add upload button conditionally
> create and use TemplateView
> create and use BackupView
> get rid of unneccessary enableFn's
> create ImageView and use it for VM and CT images
> simplify reload call
> content view: allow specifying which columns to show on init
> group backups by backup groups in backup view
> allow child classes of ContentView to specify their own listeners
> add CSS for button in grid's group header
> backup view: add prune window
>
> www/css/ext6-pve.css | 28 ++
> www/manager6/Makefile | 4 +
> www/manager6/panel/ConfigPanel.js | 93 ++---
> www/manager6/storage/BackupView.js | 128 +++++++
> www/manager6/storage/Browser.js | 97 ++++-
> www/manager6/storage/ContentView.js | 551 +++++++--------------------
> www/manager6/storage/ImageView.js | 74 ++++
> www/manager6/storage/TemplateView.js | 215 +++++++++++
> www/manager6/window/Prune.js | 306 +++++++++++++++
> 9 files changed, 1018 insertions(+), 478 deletions(-)
> create mode 100644 www/manager6/storage/BackupView.js
> create mode 100644 www/manager6/storage/ImageView.js
> create mode 100644 www/manager6/storage/TemplateView.js
> create mode 100644 www/manager6/window/Prune.js
>
applied all up to the RFC patch 16/20; with a few followups, some not directly related
to your series, rather the state of the code in general.
prev parent reply other threads:[~2020-11-16 9:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:16 [pve-devel] " Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 01/20] fix extension filter for upload window Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 02/20] config panel: allow new nodes to be added later Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 03/20] storage panel/browser: use insertNodes function Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 04/20] add CD ROM and lxc icons for treelist-item-icon Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 05/20] use separate view for each content type Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 06/20] remove the now unnecessary grouping by " Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 07/20] remove the now unneccessary content type column Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 08/20] content view: allow specifying title bar elements for init Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 09/20] turn {nodename, storage, sm} into object variables Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 10/20] add upload button conditionally Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 11/20] create and use TemplateView Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 12/20] create and use BackupView Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 13/20] get rid of unneccessary enableFn's Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 14/20] create ImageView and use it for VM and CT images Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 15/20] simplify reload call Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [RFC v3 manager 16/20] content view: allow specifying which columns to show on init Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 17/20] group backups by backup groups in backup view Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 18/20] allow child classes of ContentView to specify their own listeners Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 19/20] add CSS for button in grid's group header Fabian Ebner
2020-11-13 13:16 ` [pve-devel] [PATCH v3 manager 20/20] backup view: add prune window Fabian Ebner
2020-11-16 9:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a864113-e8a2-78c6-e2a3-81ceaf2f11d6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox