* [pve-devel] [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format
@ 2023-09-18 9:49 Lukas Wagner
2023-09-18 10:07 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-09-18 9:49 UTC (permalink / raw)
To: pve-devel
Fixes: 7e4b51 ("notification config view: fix using gettext with parameter")
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/panel/NotificationConfigView.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js
index fe56102..ff9c512 100644
--- a/src/panel/NotificationConfigView.js
+++ b/src/panel/NotificationConfigView.js
@@ -101,7 +101,10 @@ Ext.define('Proxmox.panel.NotificationEndpointView', {
success: function(response, opt) {
Ext.Msg.show({
title: gettext('Notification Target Test'),
- message: Ext.String.format(gettext("Sent test notification to '{0}'.")),
+ message: Ext.String.format(
+ gettext("Sent test notification to '{0}'."),
+ target,
+ ),
buttons: Ext.Msg.OK,
icon: Ext.Msg.INFO,
});
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format
2023-09-18 9:49 [pve-devel] [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format Lukas Wagner
@ 2023-09-18 10:07 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-09-18 10:07 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 18/09/2023 um 11:49 schrieb Lukas Wagner:
> Fixes: 7e4b51 ("notification config view: fix using gettext with parameter")
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/panel/NotificationConfigView.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-18 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 9:49 [pve-devel] [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format Lukas Wagner
2023-09-18 10:07 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox