From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-cluster v2] fix #6615: rrd: only return populated entries
Date: Wed, 27 Aug 2025 10:41:15 +0200 [thread overview]
Message-ID: <49cc64ca-c155-4856-8b09-ed348d9405d5@proxmox.com> (raw)
In-Reply-To: <d005adb5-eb20-499c-b125-2127c379605f@proxmox.com>
On 11.08.25 11:25, Dominik Csapak wrote:
> Hi,
>
> please correct me if I'm wrong, but wouldn't this change drastically
> change the graphs on the web ui ? (did not test it though)
>
> when e.g. a storage is offline, it will have intermediary empty values?
>
> so instead of having
> [
> { time: 1, value: 1},
> { time: 2 },
> { time: 3, value: 2}
> ]
>
> where we get a whole between 1 and 3, but with this patch we'd get
>
> [
> { time: 1, value: 1},
> { time: 3, value: 2},
> ]
>
> which would draw a line between 1 and 3 i guess?
>
It would, I didn't notice when I tested it.
Given this is only a problem for the last bucket, and only if read a few
seconds after a new one started. We can just check the last entry and
remove it if empty.
Thanks for pointing this out! I'll send a v2.
> On 8/8/25 17:07, Hannes Laimer wrote:
>> RRD fetch can include the latest bucket before metrics are flushed,
>> resulting in entries with only a timestamp.
>>
>> This now only returns entries with at least one value.
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>> since v1, thanks @Fabian:
>> - just check count of keys in entry instead of keeping track of when
>> something is added
>>
>> src/PVE/RRD.pm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm
>> index 8fe1927..1813cdb 100644
>> --- a/src/PVE/RRD.pm
>> +++ b/src/PVE/RRD.pm
>> @@ -78,7 +78,8 @@ sub create_rrd_data {
>> # maybe make this configurable?
>> }
>> }
>> - push @$res, $entry;
>> + # 'time' + at least one metric
>> + push @$res, $entry if (scalar keys %$entry) > 1;
>> }
>> return $res;
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-27 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 15:08 Hannes Laimer
2025-08-11 9:25 ` Dominik Csapak
2025-08-27 8:41 ` Hannes Laimer [this message]
2025-08-27 9:05 ` [pve-devel] superseded: " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49cc64ca-c155-4856-8b09-ed348d9405d5@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox