public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/2] permpathstore: add sdn zones
Date: Tue, 24 Aug 2021 11:06:46 +0200	[thread overview]
Message-ID: <49b6244d-b23a-f201-2f52-500fd10fa1c2@proxmox.com> (raw)
In-Reply-To: <20210805145900.3265228-3-aderumier@odiso.com>

On 05/08/2021 16:58, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  www/manager6/data/PermPathStore.js | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js
> index 1dc276b6..cf702c03 100644
> --- a/www/manager6/data/PermPathStore.js
> +++ b/www/manager6/data/PermPathStore.js
> @@ -10,6 +10,7 @@ Ext.define('PVE.data.PermPathStore', {
>  	{ 'value': '/access/realm' },
>  	{ 'value': '/nodes' },
>  	{ 'value': '/pool' },
> +	{ 'value': '/sdn/zones' },

Would need guarding similar to how we hide other SDN stuff for now, else it could be
confusing to some. I.e., adding something like the following stanza in the constructor
between the suspendEvents and resumeEvents calls:

if (PVE.SDNInfo) {
  me.add({ value: '/sdn/zones' });
}



>  	{ 'value': '/storage' },
>  	{ 'value': '/vms' },
>      ],
> @@ -32,6 +33,8 @@ Ext.define('PVE.data.PermPathStore', {
>  		    break;
>  		case 'lxc': path = '/vms/' + record.get('vmid');
>  		    break;
> +		case 'sdn': path = '/sdn/zones/' + record.get('sdn');
> +		    break;
>  		case 'storage': path = '/storage/' + record.get('storage');
>  		    break;
>  		case 'pool': path = '/pool/' + record.get('pool');
> 





  reply	other threads:[~2021-08-24  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 14:58 [pve-devel] [PATCH pve-manager 0/2] sdn: permissions improvments Alexandre Derumier
2021-08-05 14:58 ` [pve-devel] [PATCH pve-manager 1/1] api2 : network: anybridge: don't display bridges if user have access to vnets Alexandre Derumier
2021-08-05 14:58 ` [pve-devel] [PATCH pve-manager 1/2] permpathstore: add sdn zones Alexandre Derumier
2021-08-24  9:06   ` Thomas Lamprecht [this message]
2021-08-05 14:59 ` [pve-devel] [PATCH pve-manager 2/2] api2 : network: anybridge: don't display bridges if user have access to vnets Alexandre Derumier
2021-08-07 16:00   ` alexandre derumier
2021-08-23 16:39     ` Thomas Lamprecht
2021-08-24  6:12       ` alexandre derumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49b6244d-b23a-f201-2f52-500fd10fa1c2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal