From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check
Date: Wed, 30 Aug 2023 11:27:54 +0200 [thread overview]
Message-ID: <49a766d4-142d-417f-826b-da63ca5e52f8@proxmox.com> (raw)
In-Reply-To: <20230627074849.10038-1-f.ebner@proxmox.com>
Am 27/06/2023 um 09:48 schrieb Fiona Ebner:
> instead of claiming that the storage is not online.
>
> Would've made the issue fixed by b27da68 ("cifs: fix check connection
> call") more obvious, because (the UI passes along an empty string for
> domain if not set and) the smbclient call returns that status with
>> -W ''
> in Bookworm.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Storage/CIFSPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-08-30 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:48 [pve-devel] " Fiona Ebner
2023-08-30 9:13 ` Fiona Ebner
2023-08-30 9:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a766d4-142d-417f-826b-da63ca5e52f8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox