From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [PATCH v1 pve-common 2/4] add tests for PVE::Path
Date: Thu, 19 Dec 2024 20:08:04 +0100 [thread overview]
Message-ID: <4990a4b4-5027-4db2-9909-d36af8a54a07@proxmox.com> (raw)
In-Reply-To: <20241219183143.526267-3-m.carrara@proxmox.com>
Am 19.12.24 um 19:31 schrieb Max Carrara:
> This commit adds a plethora of parameterized tests for all functions
> of PVE::Path (except aliases). This surmounts to 1050 tests being run
> in total. Some of these tests might perhaps be redundant, but the goal
> here was to be better safe than sorry and really make sure that
> nothing slips through.
IMO that's a little bit contradictory, as redundant tests, or not knowing
how much redundancy there is making me a bit question if this is really
worth it. I'd rather see much fewer tests but with a clear plan/idea for
what they are for; as of is this is not really reviewable and without
knowing how they got created and how much it was made sure that we do not
test ten times the same thing.
I do not want to say you do, but would like some more reasoning here than
"trust me bro" and if we can have 100, or even less, tests with the same
coverage it would be a big improvement, as that makes them much more
maintainable.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-19 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 18:31 [pve-devel] [PATCH v1 pve-common 0/4] Introduce and Package PVE::Path & PVE::Filesystem Max Carrara
2024-12-19 18:31 ` [pve-devel] [PATCH v1 pve-common 1/4] introduce PVE::Path Max Carrara
2024-12-19 18:31 ` [pve-devel] [PATCH v1 pve-common 2/4] add tests for PVE::Path Max Carrara
2024-12-19 19:08 ` Thomas Lamprecht [this message]
2024-12-20 11:06 ` Max Carrara
2024-12-19 18:31 ` [pve-devel] [PATCH v1 pve-common 3/4] introduce PVE::Filesystem Max Carrara
2024-12-19 18:31 ` [pve-devel] [PATCH v1 pve-common 4/4] debian: introduce package libproxmox-fs-path-utils-perl Max Carrara
2024-12-20 18:55 ` [pve-devel] [PATCH v1 pve-common 0/4] Introduce and Package PVE::Path & PVE::Filesystem Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4990a4b4-5027-4db2-9909-d36af8a54a07@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox