Re: [pve-devel] [PATCH guest-common 1/1] vzdump: schema: add 'notes' and 'protected' properties

[Fabian Ebner <f.ebner@proxmox.com>]

Am 17.03.22 um 09:07 schrieb Thomas Lamprecht:
> On 17.03.22 08:57, Fabian Ebner wrote:
>> Am 16.03.22 um 19:25 schrieb Thomas Lamprecht:
>>>
>>> While extending one has a slight chance of changing an existing setup I find
>>> this very unlikely in this specific case, as we had no such feature whatsoever
>>> and it makes not sense in any practical example to use such special strings
>>> for a backup comment.
>>
>> Yes, I'd simply document the list of currently valid variables, and that
>> it might be extended in the future.
>>
> 
> k.
> 
> a subset of the VM config could be possibly interesting too (e.g., ostype, first
> line of description) but as the config is already in the backup it may not be worth
> it - so maybe better to wait for the non-obvious variables for users to actually
> requesting them.
> 

Ok

>>>
>>> That said, if one can whip up another reason besides backward compat for
>>> having a separate flag to turn this on/off then feel free to comment.
>>>
>>> I mean, for the backup jobs itself it could have some value to differ
>>> between the comment about the job itself and a comment template for the
>>> resulting backups.
>>
>> Yes, I think it'd be better to not mix the job's comment (which is part
>> of the generic job properties) and the vzdump-specific notes{-template}
>> which this patch (or rather a future version of it) will introduce.
> 
> Agree. So, to summarize, vzdump does the interpreting for a plain, new `--notes`
> CLI which it also prints (with variables already resolved) in the task log and
> sets that also as note for the (created) backup.
> 
> The job config would get a new notes-template config that allows to add such
> a dynamically interpreted string to each backup created by this job by bassing
> it as --notes to vzdump. That way we avoid vzdump having two different, clashing,
> CLI options but keep it cleanly separated for the job definitions.

I think it'd be better or even necessary for vzdump to do the variable
expansion, because some things are not known when we start the job, for
example guest name. It'd then be enough to add a notes-template option
for vzdump, and have the job pass it along as-is with the rest of the
vzdump-config.