public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: alexandre derumier <aderumier@odiso.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] ovf duplicate AddressOnParent
Date: Mon, 21 Dec 2020 18:04:21 +0100	[thread overview]
Message-ID: <495cb97d-d453-7ac6-617d-e95101fa832a@odiso.com> (raw)
In-Reply-To: <c40b0642-2a98-2636-1480-55261126c8db@proxmox.com>

mmm, seem that

AddressOnParent is indeed the disk location on the controller,

but on the provided ovf example, they are 2 differents controllers (parent=4 && parent=5)

(I don't known how vmware manage disk, 1controller with multliples disk, or 1controller by disk. Maybe it's related to vm machine version or config.)


But in the proxmox ovf parser, we only handle 1 controller


# extract corresponding Controller node details

my $adress_on_controller = $xpc->findvalue('rasd:AddressOnParent', 
$item_node);

my $pve_disk_address = id_to_pve($controller_type) . $adress_on_controller;


that's why we have a conflict here


On 21/12/2020 16:45, Thomas Lamprecht wrote:
> On 21/12/2020 16:32, alexandre derumier wrote:
>> On 03/12/2020 08:36, Dominic Jäger wrote:
>>> Please try changing the AddressOnParent values so that they are unique.
>>> As you mentioned, the disks should then be attached with different numbers scsi0, scsi1, scsi2...
>> Hi,
>>
>> I wonder if the current proxmox ovs parser is not wrong.
>>
>> Seem than "adressOnParent" is the pci controller.
>>
>> So, it's working fine for nic,  but for disks , if ovf have multiple disks on same controller, it'll be always the same AddressOnParent.
>>
> That would sound likely, but did not actually looked into it.
>
>> I'll to check with differents hypervisors ovf export to be sure.
> thanks!
>




      reply	other threads:[~2020-12-21 17:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 13:50 px
2020-12-03  7:36 ` Dominic Jäger
2020-12-21 15:32   ` alexandre derumier
2020-12-21 15:45     ` Thomas Lamprecht
2020-12-21 17:04       ` alexandre derumier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495cb97d-d453-7ac6-617d-e95101fa832a@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal