From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"
Date: Wed, 14 Jun 2023 13:44:34 +0200 [thread overview]
Message-ID: <49511c23-e5f8-4d09-d892-ff7ec4eeb44d@proxmox.com> (raw)
In-Reply-To: <6b906c73-1c4d-d29a-ff16-b7c0cf8a692d@proxmox.com>
On 6/14/23 13:38, Thomas Lamprecht wrote:
> Am 14/06/2023 um 13:28 schrieb Aaron Lauterer:
>> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
>>
>> The bug should be fixed by now [0]. The reproducer doesn't cause any
>> issues in my tests.
>>
>> [0] https://github.com/openzfs/zfs/issues/8541
>
> hmm, torn on this one; 1 MB aligned images sound not to bad for various things,
> and the extra size is rather negligible most of the time so we can mostly lose
> here, otoh. it should be callers decision if storage works fine now..
>
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> AFAICT this has an affect on EFI disks which after this revert will be
>> 528k and not 1M. Similar as if we would store it as a .raw file.
>>
>
> that sounds like it _could_ break stuff..
>
> @fiona: what was the state with local storage migration and those disk size
> mismatches? Or anything else coming to your mind?
I did a few tests in the meantime. An EFI disk on a directory based storage will
be 528 K and can be moved to a ZFS storage with this patch. Without it, it will
fail, similar to RBD which needs a 1M min size IIRC.
next prev parent reply other threads:[~2023-06-14 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:28 Aaron Lauterer
2023-06-14 11:38 ` Thomas Lamprecht
2023-06-14 11:44 ` Aaron Lauterer [this message]
2023-06-14 12:13 ` Fiona Ebner
2023-06-14 12:26 ` Aaron Lauterer
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 13:54 Aaron Lauterer
2021-06-10 12:33 ` Fabian Ebner
2021-06-11 9:28 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49511c23-e5f8-4d09-d892-ff7ec4eeb44d@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox