Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property
Date: Tue, 8 Apr 2025 11:10:47 +0200	[thread overview]
Message-ID: <492ef733-beac-4370-85d3-cbc3075c7ab1@proxmox.com> (raw)
In-Reply-To: <cdc75662-760b-4e46-8089-735c82fe939d@proxmox.com>

On  2025-04-08  09:49, Fiona Ebner wrote:
> Am 07.04.25 um 18:27 schrieb Aaron Lauterer:
>> @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({
>>   
>>   	$status->{ha} = PVE::HA::Config::get_service_status("vm:$param->{vmid}");
>>   
>> +	$status->{display}->{type} = 'std';
> 
> This is not the correct default in all cases (e.g. aarch64 VM, old
> Windows). Please use the get_vga_properties() helper from QemuServer.pm
> (you'll need to make it public by dropping its "my" of course).

Thanks! Will do

> 
>>   	if ($conf->{vga}) {
>>   	    my $vga = PVE::QemuServer::parse_vga($conf->{vga});
>> +	    $status->{display}->{type} = $vga->{type} if defined($vga->{type});
>> +
>>   	    my $spice = defined($vga->{type}) && $vga->{type} =~ /^virtio/;
>>   	    $spice ||= PVE::QemuServer::vga_conf_has_spice($conf->{vga});
>>   	    $status->{spice} = 1 if $spice;
> 

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel