public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH spiceterm] screen.c: fix exiting on client disconnect
Date: Wed, 23 Jun 2021 10:13:47 +0200	[thread overview]
Message-ID: <488840ae-f73a-5436-6bfe-a455010bc2fc@proxmox.com> (raw)
In-Reply-To: <20210623074532.12141-1-d.csapak@proxmox.com>

On 23.06.21 09:45, Dominik Csapak wrote:
> the way we detected a client_disconnect does not work anymore with
> spice-server >= 0.14.3, but there is a convienient function
> that exits the spice-server on client disconnect
> 
> there is a slight behaviour change that should not make a big difference:
> 
> previously, if a user used the same '.vv' file twice, the first client
> got disconnected and the second would connect
> 
> now, because the server closes on disconnect, the second client is
> not be able to connect anymore
> 
> using our ui though, every click on 'shell>spice' generates a new '.vv'
> file that works though (and for container shells we use dtach to mux)
> 
> i could not (in reasonable time) find out why the first client
> disconnects at all, and also could not find another way to detect a
> client disconnect that is similar to our previous method
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/screen.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




      parent reply	other threads:[~2021-06-23  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  7:45 [pve-devel] " Dominik Csapak
2021-06-23  7:59 ` Dominik Csapak
2021-06-23  8:13 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488840ae-f73a-5436-6bfe-a455010bc2fc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal