public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 manager] api: apt: repos: fix interfacing with perlmod
Date: Thu, 17 Feb 2022 14:34:54 +0100	[thread overview]
Message-ID: <48708305-ec3a-31d8-1c7d-64dce731c3f4@proxmox.com> (raw)
In-Reply-To: <20210716132753.102535-1-f.ebner@proxmox.com>

On 16.07.21 15:27, Fabian Ebner wrote:
> Using
>     pvesh create /nodes/pve701/apt/repositories --path
>     "/etc/apt/sources.list" --index 0 --enabled 1
> reliably leads to
>     error: invalid type: string "0", expected usize
> 
> Coerce to int to avoid this. I was not able to trigger the issue with
> the "enabled" option being a string here (in PMG I was), but be on the
> safe side and coerce there too. Otherwise it might get triggered by a
> future, completely unrelated change further up in the API call
> handling.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v3:
>     * shorter/cleaner code, but now there's no good reason for the
>       comment anymore, because it's arguably the better code even
>       without the perlmod limitation. But I do have a reproducer, so
>       hopefully the issue can be fixed in perlmod before somebody else
>       runs into it.
> 
>  PVE/API2/APT.pm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
>

sorry I thought this was already done, now applied, thanks!




      parent reply	other threads:[~2022-02-17 13:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 13:27 [pve-devel] " Fabian Ebner
2021-11-18 13:03 ` Fabian Ebner
2022-02-16  7:36 ` Fabian Ebner
2022-02-17 13:34 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48708305-ec3a-31d8-1c7d-64dce731c3f4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal