Re: [pve-devel] applied: [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm

[Christoph Heiss <c.heiss@proxmox.com>]

On Tue, Feb 06, 2024 at 01:17:57PM +0100, Thomas Lamprecht wrote:
> Am 22/12/2023 um 11:52 schrieb Christoph Heiss:
> > Fletcher-2 has long been deprecated and should not be used anymore
> > [0][1], so we probably should not offer it anymore too. It's been
> > deprecated since at least over 3 years, beyond that it's hard to find an
> > exact date.
> >
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> >
> > [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#checksum-algorithms
> > [1] https://people.freebsd.org/~asomers/fletcher.pdf
>
> please keep the git-trailes, like your S-o-b, always at the bottom.
> References like these above are part of the commit message, not the
> Developer Certificate of Origin S-o-b or patch meta stuff like R-b
> or T-b trailers.

Oh right, sorry for that.

>
> > ---
> > Sending this as RFC since it might warrant some discussions.
> >
> > While digging into this a bit more, I reckon we should remove 'off' as
> > an option too. It's considered an "extraordinarily bad idea" [2] (for to
> > pretty obvious reason) and nobody should ever use it.
> >
> > Might be a good idea, just so that users simply disable checksum "for
> > performance reasons" without knowing about the implications of this.
>
> yeah, would make sense, especially as anybody can still disable those
> afterwards using the `zfs` CLI tool, for whatever reason that may be.
>
> The alternative would be either showing a hint if `off` is selected,
> or change the combobox entry label of it to something like:
> `off (NOT recommended)`
>
> But just to mention all options, I'm fine with this being dropped,
> if lots of users complain with somewhat reasonable justification then
> we could always re-add it with aforementioned hint.

Sounds good. I'd then prefer to just drop it as well, since setting it
to "off" is definitely something that should only be done with _very_
good reasoning anyway.

I'll send a patch.

>
> > [2] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums
> >
> >  proxinstall                             | 2 +-
> >  proxmox-installer-common/src/options.rs | 3 +--
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> >
> >
>
> applied, thanks!