From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] prune mark: correctly keep track of already included backups
Date: Mon, 14 Dec 2020 16:13:13 +0100 [thread overview]
Message-ID: <47b74601-b22d-81dc-aefd-c5599bde5125@proxmox.com> (raw)
In-Reply-To: <20201214150317.28734-1-f.ebner@proxmox.com>
On 14.12.20 16:03, Fabian Ebner wrote:
> This needs to happen in a separate loop, because some time intervals are not
> subsets of others, i.e. weeks and months. Previously, with a daily backup
> schedule, having:
> * a backup on Sun, 06 Dec 2020 kept by keep-daily
> * a backup on Sun, 29 Nov 2020 kept by keep-weekly
> would lead to the backup on Mon, 30 Nov 2020 to be selected for keep-monthly,
> because the iteration did not yet reach the backup on Sun, 29 Nov 2020 that
> would mark November as being covered.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> The PBS implementation is not affected by this as it uses two loops.
> I don't see how this would cause bug #3199 though...
>
> PVE/Storage.pm | 11 +++++----
> test/prune_backups_test.pm | 49 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 55 insertions(+), 5 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-12-14 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 15:03 [pve-devel] " Fabian Ebner
2020-12-14 15:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b74601-b22d-81dc-aefd-c5599bde5125@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox