* [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column
@ 2023-07-18 9:53 Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
2023-09-01 7:46 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-07-18 9:53 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/Backup.js | 3 +--
www/manager6/grid/Replication.js | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 03a02651..e662dd36 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -722,8 +722,7 @@ Ext.define('PVE.dc.BackupView', {
width: 80,
dataIndex: 'enabled',
align: 'center',
- // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
- renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
+ renderer: Proxmox.Utils.renderEnabledIcon,
sortable: true,
},
{
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index 30cd6718..1e4e00fc 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -283,8 +283,7 @@ Ext.define('PVE.grid.ReplicaView', {
width: 80,
dataIndex: 'enabled',
align: 'center',
- // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
- renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
+ renderer: Proxmox.Utils.renderEnabledIcon,
sortable: true,
},
{
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column
2023-07-18 9:53 [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column Lukas Wagner
@ 2023-09-01 6:55 ` Lukas Wagner
2023-09-01 7:46 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-09-01 6:55 UTC (permalink / raw)
To: pve-devel
Ping
On 7/18/23 11:53, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 3 +--
> www/manager6/grid/Replication.js | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 03a02651..e662dd36 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -722,8 +722,7 @@ Ext.define('PVE.dc.BackupView', {
> width: 80,
> dataIndex: 'enabled',
> align: 'center',
> - // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> - renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> + renderer: Proxmox.Utils.renderEnabledIcon,
> sortable: true,
> },
> {
> diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
> index 30cd6718..1e4e00fc 100644
> --- a/www/manager6/grid/Replication.js
> +++ b/www/manager6/grid/Replication.js
> @@ -283,8 +283,7 @@ Ext.define('PVE.grid.ReplicaView', {
> width: 80,
> dataIndex: 'enabled',
> align: 'center',
> - // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> - renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> + renderer: Proxmox.Utils.renderEnabledIcon,
> sortable: true,
> },
> {
--
- Lukas
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column
2023-07-18 9:53 [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
@ 2023-09-01 7:46 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-09-01 7:46 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 18/07/2023 um 11:53 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 3 +--
> www/manager6/grid/Replication.js | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>
applied, but added context about when this function got available in
widget toolkit, nad since when we can rely on that version to be
available in manager to the commit message, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-01 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 9:53 [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
2023-09-01 7:46 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox