public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] fix #4166: restore: add resource pool selector
Date: Tue, 17 Jun 2025 17:45:15 +0200	[thread overview]
Message-ID: <476107cf-2197-46ba-890c-a7c91aaf636f@proxmox.com> (raw)
In-Reply-To: <20250612082318.118153-1-m.sandoval@proxmox.com>

Am 12.06.25 um 10:23 schrieb Maximiliano Sandoval:
> The pool selector is only visible when restoring from the
> Datacenter->{node}->{storage}->Backups panel.

I mean fine for now, but IMO if the user has enough rights then restoring
to another pool for when overwriting an existing VM might make sense to;
but that can definitively be an independent change.

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Differences from v1:
>  - Hide the pool selector when restoring a VM in-place.
> 
>  www/manager6/window/Restore.js | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index 22900868..6f9c9f2f 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
>  	    if (values.storage) {
>  		params.storage = values.storage;
>  	    }
> +	    if (values.pool) {
> +		params.pool = values.pool;
> +	    }
>  
>  	    ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
>  		if ((values[opt] ?? '') !== '') {
> @@ -186,6 +189,14 @@ Ext.define('PVE.window.Restore', {
>  		fieldLabel: gettext('Source'),
>  	    },
>  	    storagesel,
> +	    {
> +		xtype: 'pvePoolSelector',
> +		fieldLabel: gettext('Resource Pool'),
> +		name: 'pool',
> +		value: '',
> +		allowBlank: true,
> +		hidden: me.vmid,
> +	    },

Should this better get placed in the override section?

>  	    {
>  		xtype: 'pmxDisplayEditField',
>  		name: 'vmid',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-06-17 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  8:23 Maximiliano Sandoval
2025-06-17 15:45 ` Thomas Lamprecht [this message]
2025-06-18  8:32   ` Fiona Ebner
2025-06-25 13:48   ` Maximiliano Sandoval
2025-06-25 14:02     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476107cf-2197-46ba-890c-a7c91aaf636f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal