From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v3 2/2] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js
Date: Mon, 14 Nov 2022 20:48:24 +0100 [thread overview]
Message-ID: <475c95ed-eb66-9848-6942-5c245ce42029@proxmox.com> (raw)
In-Reply-To: <20221114113828.286081-3-s.sterz@proxmox.com>
Am 14/11/2022 um 12:38 schrieb Stefan Sterz:
> previously the widget toolkit was not scanned when creating the
> mapping between `onlineHelp` keys and pve-doc anchors. this could
> lead to cases where help buttons didn't work because the necessary
> mapping wasn't present in `OnlineHelpInfo.js`.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> debian/control | 1 +
> www/manager6/Makefile | 6 ++++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>
applied, thanks! Also bumped the versioned build-dependency to pve-doc-generator
prev parent reply other threads:[~2022-11-14 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 11:38 [pve-devel] [PATCH manager v3 0/2] pve fix help buttons by accounting for keys in widget toolkit Stefan Sterz
2022-11-14 11:38 ` [pve-devel] [PATCH docs v3 1/2] asciidoc-pve: disallow certain characters in onlineHelp keys Stefan Sterz
2022-11-14 18:50 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-14 11:38 ` [pve-devel] [PATCH manager v3 2/2] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js Stefan Sterz
2022-11-14 19:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475c95ed-eb66-9848-6942-5c245ce42029@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox