public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] api: migration preconditions: add more return type information
@ 2024-12-18 11:54 Dominik Csapak
  2024-12-18 12:44 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2024-12-18 11:54 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Qemu.pm | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c7f45051..db356b7e 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -4581,27 +4581,74 @@ __PACKAGE__->register_method({
     returns => {
 	type => "object",
 	properties => {
-	    running => { type => 'boolean' },
+	    running => {
+		type => 'boolean',
+		description => "Determines if the VM is running.",
+	    },
 	    allowed_nodes => {
 		type => 'array',
+		items => {
+		    type => 'string',
+		    description => "An allowed node",
+		},
 		optional => 1,
 		description => "List nodes allowed for offline migration, only passed if VM is offline"
 	    },
 	    not_allowed_nodes => {
 		type => 'object',
 		optional => 1,
+		properties =>  {
+		    unavailable_storages => {
+			type => 'array',
+			optional => 1,
+			description => 'A list of not available storages.',
+			items => {
+			    type => 'string',
+			    description => 'A storage',
+			},
+		    },
+		},
 		description => "List not allowed nodes with additional information, only passed if VM is offline"
 	    },
 	    local_disks => {
 		type => 'array',
+		items => {
+		    type => 'object',
+		    properties => {
+			size => {
+			    type => 'integer',
+			    description => 'The size of the disk in bytes.',
+			},
+			volid => {
+			    type => 'string',
+			    description => 'The volid of the disk.',
+			},
+			cdrom => {
+			    type => 'boolean',
+			    description => 'True if the disk is a cdrom.',
+			},
+			is_unused => {
+			    type => 'boolean',
+			    description => 'True if the disk is unused.',
+			},
+		    },
+		},
 		description => "List local disks including CD-Rom, unused and not referenced disks"
 	    },
 	    local_resources => {
 		type => 'array',
+		items => {
+		    type => 'string',
+		    description => "A local resource",
+		},
 		description => "List local resources e.g. pci, usb"
 	    },
 	    'mapped-resources' => {
 		type => 'array',
+		items => {
+		    type => 'string',
+		    description => "A mapped resource",
+		},
 		description => "List of mapped resources e.g. pci, usb"
 	    },
 	},
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH qemu-server] api: migration preconditions: add more return type information
  2024-12-18 11:54 [pve-devel] [PATCH qemu-server] api: migration preconditions: add more return type information Dominik Csapak
@ 2024-12-18 12:44 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-12-18 12:44 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

Am 18.12.24 um 12:54 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/API2/Qemu.pm | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-18 12:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-18 11:54 [pve-devel] [PATCH qemu-server] api: migration preconditions: add more return type information Dominik Csapak
2024-12-18 12:44 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal