From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] api: network: fix #3385 check for used ports before writing
Date: Thu, 22 Apr 2021 21:35:40 +0200 [thread overview]
Message-ID: <4713161e-861e-f9f0-2e3c-15d43c4ae31c@proxmox.com> (raw)
In-Reply-To: <20210419181128.4047-1-s.ivanov@proxmox.com>
On 19.04.21 20:11, Stoiko Ivanov wrote:
> Currently the check for used ports for bonds and bridges happens while
> rendering '/etc/network/interfaces.new' in PVE::Inotify (pve-common).
> However at that stage the new/updated interface is already merged with
> the old settings, making it impossible to indicate where a NIC is
> currently used.
>
> The code is adapted from the renderer in
> PVE::Inotify::__write_etc_network_interfaces.
>
> Tested on a virtual PVE instance.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> PVE/API2/Network.pm | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-04-22 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 18:11 [pve-devel] " Stoiko Ivanov
2021-04-22 19:35 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713161e-861e-f9f0-2e3c-15d43c4ae31c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox