From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v5 0/3] fix: enable noVNC console view in iOS and refactor console view implementation
Date: Wed, 17 Sep 2025 10:02:33 +0200 [thread overview]
Message-ID: <46b3641f-2a2c-4d99-9190-772866302f3d@proxmox.com> (raw)
In-Reply-To: <20250818100134.30550-1-s.shaji@proxmox.com>
On 8/18/25 12:01 PM, Shan Shaji wrote:
> On iOS the noVNC console option was not available this patch series
> includes the changes to enable the console view. Also seperate the onTap
> implementation to a seperate function as the current implementation is
> repeating.
>
> Additionaly the console view was hard to be dismissible in iOS, to fix
> it add an AppBar with back button.
>
> History:
>
> changes since v4: https://lore.proxmox.com/pve-devel/20250814093219.75803-1-s.shaji@proxmox.com/
> - Move all changes into seperate patches.
> - Remove unncessary formatting.
>
> changes since v3:
> - Remove dart formatting changes.
> - Updated commit message.
>
> changes since v2:
> - Set `resizeToAvoidBottomInset` to false to avoid the scaffold body
> to resize automatically when the keyboard pops up.
> - Update commit message.
>
> changes since v1:
> - Rebased with master.
> - Updated commit message.
>
> Shan Shaji (3):
> ui: ios: enable noVNC console support
> refactor: noVNC: seperate duplicate onTap implementation
> fix: ui: make noVNC console dismissible and prevent body resize
>
> lib/widgets/pve_console_menu_widget.dart | 56 +++++++++---------------
> 1 file changed, 20 insertions(+), 36 deletions(-)
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-17 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 10:01 [pve-devel] " Shan Shaji
2025-08-18 10:01 ` [pve-devel] [PATCH pve_flutter_frontend v5 1/3] ui: ios: enable noVNC console support Shan Shaji
2025-08-18 10:01 ` [pve-devel] [PATCH pve_flutter_frontend v5 2/3] refactor: noVNC: seperate duplicate onTap implementation Shan Shaji
2025-08-18 10:01 ` [pve-devel] [PATCH pve_flutter_frontend v5 3/3] fix: ui: make noVNC console dismissible and prevent body resize Shan Shaji
2025-09-04 7:33 ` [pve-devel] [PATCH pve_flutter_frontend v5 0/3] fix: enable noVNC console view in iOS and refactor console view implementation Shan Shaji
2025-09-17 8:02 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b3641f-2a2c-4d99-9190-772866302f3d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox