From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: ceph/Status: fix icon in status grid
Date: Fri, 18 Jun 2021 17:25:25 +0200 [thread overview]
Message-ID: <46a700cc-6ba4-a13d-837a-83129f9672cb@proxmox.com> (raw)
In-Reply-To: <20210527114248.25015-1-d.csapak@proxmox.com>
On 27.05.21 13:42, Dominik Csapak wrote:
> there was a spurious leftover single quote("'"), that prevented
> the correct css class to be inserted
> (e.g., fa-exclamation' instead of fa-exclamation)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/ceph/Status.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
> index cd6d002b..e92c698b 100644
> --- a/www/manager6/ceph/Status.js
> +++ b/www/manager6/ceph/Status.js
> @@ -86,7 +86,7 @@ Ext.define('PVE.node.CephStatus', {
> renderer: function(value) {
> let health = PVE.Utils.map_ceph_health[value];
> let icon = PVE.Utils.get_health_icon(health);
> - return `<i class="fa fa-fw ${icon}'"></i>`;
> + return `<i class="fa fa-fw ${icon}"></i>`;
> },
> sorter: {
> sorterFn: function(a, b) {
>
Seems I already applied this a few weeks ago and forgot to reply:
https://git.proxmox.com/?p=pve-manager.git;a=commit;h=c3b2a34528b40d000564c492cc0fd5ce69432c02
Any how, now I also did the missing cherry-pick to stable-6, thanks!
prev parent reply other threads:[~2021-06-18 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 11:42 [pve-devel] " Dominik Csapak
2021-06-18 15:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a700cc-6ba4-a13d-837a-83129f9672cb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox