Re: [pve-devel] [PATCH V3 qemu-server 1/3] tap_plug: add support for bridge disable learning

[Mira Limbeck <m.limbeck@proxmox.com>]

On 11/11/22 09:36, DERUMIER, Alexandre wrote:
> Le mercredi 09 novembre 2022 à 15:19 +0100, Mira Limbeck a écrit :
>>
>> Why not add the bridge in the pve-bridge script as well? This way
>> there
>> would be no need for patch 2 for qemu-server since we always add the
>> MAC
>> address to the FDB whenever the tap device is plugged.
>>
>> If we then remove it in the pve-bridgedown script, there should be no
>> need for patch 3, right?
>>
>>
> ok, I review the whole patch serie, the current behaviour is good.
> (Seem the workflow I have send in my previous comment on patch3)
>
>
> We can't add fdb entry inconditionally in pve-bridge,as on live
> migration, we don't want to add fdb entry until the migration is
> finished.
>
> (If we do that, the others vms on the target host, will not be able to
> communicate with source vms during the migration)
>
Wouldn't it still send the traffic to the source VM while the entry is 
still alive?

But since you're a lot more knowledgeable about networks, I trust your 
judgement in this case.


In this case consider the 3 qemu-server patches:

Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>

Tested-by: Mira Limbeck <m.limbeck@proxmox.com>


The pve-network patch has only been tested without SDN for now, I'll try 
to set something up to test it with SDN as well.

The pve-container patch is on my todo list as well.