From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [RFC PATCH qemu-server] fix bootdisk_size for new bootorder config scheme
Date: Thu, 29 Apr 2021 16:19:22 +0200 [thread overview]
Message-ID: <468bae39-cfe4-88c2-18e6-eb1cb2d305d1@proxmox.com> (raw)
In-Reply-To: <20210308134338.31391-1-d.csapak@proxmox.com>
On 08.03.21 14:43, Dominik Csapak wrote:
> Previously, we ever only had a single boot *disk*, while possibly
> having multiple cdroms/nics in the boot order
>
> e.g. the config:
>
> boot: dnc
> bootdisk: scsi0
> ide0: media=cdrom,none
> scsi0: xxx
> net0: ...
>
> would return the size of scsi0 even though it would first boot
> from cdrom/network.
>
> When editing the bootorder with such a legacy config, we
> remove the 'bootdisk' property and replace the legacy notation
> with an explicit order, but we only search the first disk
> for the size now.
>
> Restore that behaviour by iterating over all disks in the boot
> order property string until we get one that is not a cdrom
> and has a size.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i cannot remember if that change was deliberate, but at least one
> user ran into that:
>
> https://forum.proxmox.com/threads/possible-bug-boot-disk-size-shows-as-0b.85454/
>
> PVE/QemuServer/Drive.pm | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-04-29 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 13:43 [pve-devel] " Dominik Csapak
2021-04-22 20:02 ` Thomas Lamprecht
2021-04-26 8:29 ` Stefan Reiter
2021-04-29 14:19 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468bae39-cfe4-88c2-18e6-eb1cb2d305d1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox