From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [RFC manager 0/4] Ceph add basic erasure code pool mgmt support
Date: Wed, 27 Apr 2022 15:37:05 +0200 [thread overview]
Message-ID: <4655fb6d-187d-4af4-d9b0-ed4f196cbb70@proxmox.com> (raw)
In-Reply-To: <20220408101416.165312-1-a.lauterer@proxmox.com>
sent some replies to the relevant parts,
all in all seems to work ok (nothing major functionally)
regarding cli, ecprofile is fine imo, i don't think we have to write out
'erasure-code-profile' in our cli (should be clear from context)
the only thing we might want to do is to (optionally?) create an ec profile on the fly
when creating a pool by giving k/m directly there?
i guess you did not do it because we already must expose the profile management
since it does not get auto cleaned up? (though could we do that on pool delete?)
we could save the whole ec profile management by always explicitly creating a new one
for each ecpool we create, so the cleanup 'should' work on pool delete.
(that will run into an error anyway if it's still used)
prev parent reply other threads:[~2022-04-27 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:14 Aaron Lauterer
2022-04-08 10:14 ` [pve-devel] [PATCH manager 1/4] api: ceph: $get_storages check if data-pool too Aaron Lauterer
2022-04-08 10:14 ` [pve-devel] [RFC manager 2/4] pveceph: add management for erasure code rules Aaron Lauterer
2022-04-27 13:32 ` Dominik Csapak
2022-04-08 10:14 ` [pve-devel] [RFC manager 3/4] ceph tools: add check if erasure code profile exists Aaron Lauterer
2022-04-08 10:14 ` [pve-devel] [PATCH manager 4/4] ceph pools: allow to create erasure code pools Aaron Lauterer
2022-04-27 13:32 ` Dominik Csapak
2022-04-08 11:13 ` [pve-devel] [RFC manager 0/4] Ceph add basic erasure code pool mgmt support Aaron Lauterer
2022-04-27 13:37 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4655fb6d-187d-4af4-d9b0-ed4f196cbb70@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox