From: Friedrich Weber <f.weber@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH ceph master 1/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes
Date: Fri, 16 Feb 2024 14:54:05 +0100 [thread overview]
Message-ID: <45d9bc1b-0d69-43c2-9aa3-3066e72a4612@proxmox.com> (raw)
In-Reply-To: <2e541a87-4996-4630-b4bf-87f8308463b5@proxmox.com>
On 15/02/2024 14:16, Thomas Lamprecht wrote:
[...]
>
> applied, thanks!
>
> as talked off-list, ceph is really not trying to reduce confusion potential
> doing things like:
>
> install -D -m 644 etc/sysctl/90-ceph-osd.conf $(DESTDIR)/etc/sysctl.d/30-ceph-osd.conf
>
> I.e., having it checked in as 90-... but installing it as 30-..
Seems like the rpm installs it as 90-ceph-osd.conf though :)
https://github.com/ceph/ceph/blob/fda8b5acbd7381dc4d86d7df5389e22aacffec22/ceph.spec.in#L1526
> And while I think the argument for "admin could have overrides that this
> affects", which you mentioned that Fabian brought up off-list, is fine,
> but is just as true on initial installation.
>
> What might be better is one (or some) of:
[...]> - drop our odd disabling of the `net.bridge.bridge-nf-call-iptables`
For PVE this might make sense independently of what ceph-osd postinst
does. We've been explicitly disabling the setting since 2012 though [1]
-- will try to find out if this is still needed. If we drop it, would
this be a breaking chance and need to wait for PVE 9?
[1]
https://git.proxmox.com/?p=pve-cluster.git;a=commit;h=501839cac97f68d4dcba21df6fb3797b976e9e56
next prev parent reply other threads:[~2024-02-16 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 9:40 [pve-devel] [PATCH ceph master+quincy-stable-8 0/3] fix #5213: avoid connection freezes when installing/upgrading ceph-osd Friedrich Weber
2024-02-15 9:40 ` [pve-devel] [PATCH ceph master 1/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes Friedrich Weber
2024-02-15 13:16 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-16 13:54 ` Friedrich Weber [this message]
2024-02-15 9:40 ` [pve-devel] [PATCH ceph quincy-stable-8 2/3] " Friedrich Weber
2024-02-15 13:17 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-15 9:40 ` [pve-devel] [PATCH ceph master 3/3] buildsys: add check for changed ceph-osd sysctl settings Friedrich Weber
2024-02-15 13:20 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d9bc1b-0d69-43c2-9aa3-3066e72a4612@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox