From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] ui: ha: consider status/presence of qdevice for warning
Date: Fri, 12 Sep 2025 18:36:13 +0200 [thread overview]
Message-ID: <45d70e96-74eb-46cf-84e5-752ad89854b8@proxmox.com> (raw)
In-Reply-To: <20250912101646.21362-1-h.laimer@proxmox.com>
Am 12.09.25 um 12:17 schrieb Hannes Laimer:
> We showed this warning for setups with two nodes and a qdevice, but for
> setups like this this warning didn't make Sense. This checks if a
> qdevice is connected to the cluster before showing the 'not enough votes
> for reliable HA'-warning.
Maybe it would be a bit more robust if we fleece that info in already in
the backend – but disclaimer: I did not just check, so you really need
to evaluate if it indeed makes sense or if applying this now as is might
be the better route forward.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> This came up in support[1].
>
> [1] https://my.proxmox.com/en/dbsfk/ticket/view/20332
>
> www/manager6/ha/ResourceEdit.js | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
> index 428672a8..04795da7 100644
> --- a/www/manager6/ha/ResourceEdit.js
> +++ b/www/manager6/ha/ResourceEdit.js
> @@ -54,7 +54,18 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
> });
>
> if (votes < MIN_QUORUM_VOTES) {
> - fewVotesHint.setVisible(true);
> + Proxmox.Utils.API2Request({
> + url: '/cluster/config/qdevice',
> + method: 'GET',
> + failure: function (response) {
> + fewVotesHint.setVisible(true);
> + },
> + success: function (response) {
> + let qdeviceStatus = response.result.data;
> + let qdeviceConnected = qdeviceStatus.State === 'Connected';
> + fewVotesHint.setVisible(!qdeviceConnected);
> + },
> + });
nit: I would slightly prefer such inline requests to use the async
Proxmox.Async.api2 method, that makes the code-flow a bit more linear
and easier to grasp.
> }
> },
> });
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-12 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 10:16 Hannes Laimer
2025-09-12 16:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d70e96-74eb-46cf-84e5-752ad89854b8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox