From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH] ignore HUP before client connect on pty
Date: Wed, 22 Apr 2026 12:03:37 +0200 [thread overview]
Message-ID: <4585f723-77b6-4c42-b811-30a9dccf5a00@proxmox.com> (raw)
In-Reply-To: <20260422085520.959328-1-d.csapak@proxmox.com>
Am 22.04.26 um 10:54 AM schrieb Dominik Csapak:
> Since debian trixie, the `login` tool timing changed and it always sends
> a HUP first thing. This caused spiceterm to immediately close again.
>
> To fix that, ignore all HUPs on the PTY side until at least one client
> is connected.
>
> To achieve that the client count is moved inside the SpiceScreen struct,
> since that is reachable from all callbacks needed
> (connect/disconnect/timeout/channel watcher).
>
> The only potential downside is if the cmd really exits before a client
> connects, it blocks the client for a bit without any indication as to
> why and then disconnects. Tested that by replacing `login` with
> `/bin/false` and the client disconnected after a few seconds
> automatically.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2026-04-22 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 8:52 Dominik Csapak
2026-04-22 8:55 ` Dominik Csapak
2026-04-22 10:03 ` Fiona Ebner [this message]
2026-04-22 10:36 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4585f723-77b6-4c42-b811-30a9dccf5a00@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox