From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2] zfs: create dataset var-lib-vz for /var/lib/vz
Date: Tue, 21 Nov 2023 14:22:47 +0100 [thread overview]
Message-ID: <44d9b8e9-a59e-4af8-91fe-74c153001dbd@proxmox.com> (raw)
In-Reply-To: <20231121131118.717293-1-s.ivanov@proxmox.com>
Am 21/11/2023 um 14:11 schrieb Stoiko Ivanov:
> Creating rpool/var/lib/vz and all intermediate datasets causes a
> service-failure of `var.mount` upon shutdown.
>
> creating the dataset for /var/lib/vz directly at the rpool and setting
> its mountpoint property seems the most robust way to address this.
>
> The alternative approach of setting `canmount=off` on the `var`
> dataset seems a bit dangerous (users setting a zfs property and
> suddenly hiding their /var contents).
>
> The only small downside to this approach is that the setting of the
> mountpoint happens quite a bit after extracting the data - but this
> would probably be better addressed with a refactoring of the
> lowlevel-installer code (setting the zfs-pool up under /target and
> getting rid of a few special cases)
>
> Fixes: dd19d40ceac179ba18652f1d6c3e4c23f246af00
> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> huge Thanks to Fabian - for the feedback and patiently walking me through
> the potential pitfalls!
>
> Proxmox/Install.pm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-11-21 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 13:11 [pve-devel] " Stoiko Ivanov
2023-11-21 13:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44d9b8e9-a59e-4af8-91fe-74c153001dbd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox