From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 widget-toolkit 4/4] utils: task_desc_table: add qmreassign
Date: Mon, 21 Sep 2020 14:09:15 +0200 [thread overview]
Message-ID: <44c93a7c-576e-3983-b13a-5ebb49388c27@proxmox.com> (raw)
In-Reply-To: <20200910143242.20898-5-a.lauterer@proxmox.com>
On 10.09.20 16:32, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> rfc -> v1 -> v2 -> v3: nothing changed
>
> src/Utils.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/Utils.js b/src/Utils.js
> index 8595cce..af41f33 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -587,6 +587,7 @@ utilities: {
> qmigrate: ['VM', gettext('Migrate')],
> qmclone: ['VM', gettext('Clone')],
> qmmove: ['VM', gettext('Move disk')],
> + qmreassign: ['VM', gettext('Reassign disk')],
> qmtemplate: ['VM', gettext('Convert to template')],
> qmstart: ['VM', gettext('Start')],
> qmstop: ['VM', gettext('Stop')],
>
I'd like to avoid adding new project specific task descriptions in widget toolkit.
Rather use the Proxmox.Utils.override_task_descriptions [0] in pve-manager to add
such project specific task descriptions. See Proxmox Backup Server UI for an usage
example [1].
[0]: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=blob;f=src/Utils.js;h=8595ccec41e00aed5790af1a6ad5cfcd0e35674c;hb=HEAD#l653
[1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=www/Utils.js;h=7bcf1ba613fb6d0c52d7d862ba0d0264f1b738c0;hb=HEAD#l93
prev parent reply other threads:[~2020-09-21 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 14:32 [pve-devel] [PATCH v3 series 0/4] disk reassign: add new feature Aaron Lauterer
2020-09-10 14:32 ` [pve-devel] [PATCH v3 qemu-server 1/4] disk reassign: add API endpoint Aaron Lauterer
2020-09-10 14:32 ` [pve-devel] [PATCH v3 qemu-server 2/4] cli: disk reassign: add reassign_disk to qm command Aaron Lauterer
2020-09-10 14:32 ` [pve-devel] [PATCH v3 storage 3/4] add disk reassign feature Aaron Lauterer
2020-09-18 14:24 ` Thomas Lamprecht
2020-09-18 15:07 ` Aaron Lauterer
2020-09-21 11:11 ` Thomas Lamprecht
2020-09-10 14:32 ` [pve-devel] [PATCH v3 widget-toolkit 4/4] utils: task_desc_table: add qmreassign Aaron Lauterer
2020-09-21 12:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44c93a7c-576e-3983-b13a-5ebb49388c27@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox