From: Stefan Sterz <s.sterz@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server v2] cdrom handling: default to "none" if no physical drive is available
Date: Mon, 19 Dec 2022 12:24:03 +0100 [thread overview]
Message-ID: <445fa5dd-e4dc-c5e1-306a-67acd324c5e2@proxmox.com> (raw)
In-Reply-To: <564d84e1-95e0-b3d7-16e3-3df55143d0dc@proxmox.com>
On 12/19/22 12:23, Fiona Ebner wrote:
> Am 19.12.22 um 12:14 schrieb Stefan Sterz:
>> when a vm is configured to use the physical cd rom drive but there is
>> no such drive a cryptic "uninitialized value" error is thrown. this
>> is due to `$path` not being defined in `sub
>> print_drive_commandline_full` in this case. warn that no cd rom drive
>> is available and default back to using "none" as media instead.
>>
>> note that the error was basically cosmetic as the vm would start just
>> fine.
>>
>> forum thread: https://forum.proxmox.com/threads/119592/
>>
>> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
>> ---
>> changes from v1: make the error message more concise. use shorter
>> forum link for better formatting in commit message (thanks @
>> Fiona Ebner).
>>
>> PVE/QemuServer.pm | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index dd6ea3e..d2f2094 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -1292,6 +1292,9 @@ sub get_cdrom_path {
>> return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom";
>> return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1";
>> return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2";
>> +
>> + warn "no physical cdrom available, defaulting back to 'none'";
>
> It's still having the very same issues as in v1.
>
>> + return '';
>> }
>>
>> sub get_iso_path {
yeah sorry, missed that, just send a mail. disregard this. sorry.
prev parent reply other threads:[~2022-12-19 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 11:14 Stefan Sterz
2022-12-19 11:23 ` Fiona Ebner
2022-12-19 11:24 ` Stefan Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445fa5dd-e4dc-c5e1-306a-67acd324c5e2@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox