From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: [pve-devel] applied: [PATCH novnc v14 4/6] add "show clipboard button" patch to series
Date: Sat, 18 Nov 2023 17:34:42 +0100 [thread overview]
Message-ID: <445daba3-379a-476b-8fb3-9cf4ed3462b9@proxmox.com> (raw)
In-Reply-To: <20231114092256.86137-5-m.frank@proxmox.com>
please add some reference for why you do this next time,
"qemu-server will gain VGA clipboard support so this can be used
for virtual machines too in the future"
could be already enough, as then one knows where to look at for
information about where this is used.
Am 14/11/2023 um 10:22 schrieb Markus Frank:
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
this order is wrong, trailers should only grow downwards, so when you picked
up Dominik's R-b and T-b it should have been added at the end.
> ---
> .../patches/0019-show-clipboard-button.patch | 30 +++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 31 insertions(+)
> create mode 100644 debian/patches/0019-show-clipboard-button.patch
>
>
applied, thanks!
next prev parent reply other threads:[~2023-11-18 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:22 [pve-devel] [PATCH qemu-server/novnc/manager/docs v14 0/6] Feature VNC-Clipboard Markus Frank
2023-11-14 9:22 ` [pve-devel] [PATCH qemu-server v14 1/6] enable VNC clipboard parameter in vga_fmt Markus Frank
2023-11-20 15:37 ` [pve-devel] partially-applied-series: " Thomas Lamprecht
2023-11-14 9:22 ` [pve-devel] [PATCH qemu-server v14 2/6] add clipboard variable to return at status/current Markus Frank
2023-11-14 9:22 ` [pve-devel] [PATCH qemu-server v14 3/6] test cases for clipboard spice & std Markus Frank
2023-11-14 9:22 ` [pve-devel] [PATCH novnc v14 4/6] add "show clipboard button" patch to series Markus Frank
2023-11-18 16:34 ` Thomas Lamprecht [this message]
2023-11-14 9:22 ` [pve-devel] [PATCH manager v14 5/6] add clipboard checkbox to VM Options Markus Frank
2023-11-17 15:07 ` Dominik Csapak
2023-11-14 9:22 ` [pve-devel] [PATCH docs v14 6/6] add VNC clipboard documentation Markus Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445daba3-379a-476b-8fb3-9cf4ed3462b9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox