Re: [pve-devel] [PATCH pve_flutter_frontend 1/3] add class for Proxmox corporate identity colors

[Tim Marx <t.marx@proxmox.com>]

> Aaron Lauterer <a.lauterer@proxmox.com> hat am 28.09.2020 14:28 geschrieben:
> 
>  
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  lib/main.dart                              |  3 ++-
>  lib/utils/promox_colors.dart               | 10 ++++++++++
>  lib/widgets/pve_guest_overview_header.dart |  3 ++-
>  lib/widgets/pve_node_overview.dart         |  3 ++-
>  4 files changed, 16 insertions(+), 3 deletions(-)
>  create mode 100644 lib/utils/promox_colors.dart
> 
> diff --git a/lib/main.dart b/lib/main.dart
> index d720225..8cd6c36 100644
> --- a/lib/main.dart
> +++ b/lib/main.dart
> @@ -28,6 +28,7 @@ import 'package:pve_flutter_frontend/widgets/pve_lxc_overview.dart';
>  import 'package:pve_flutter_frontend/widgets/pve_node_overview.dart';
>  import 'package:pve_flutter_frontend/widgets/pve_qemu_overview.dart';
>  import 'package:pve_flutter_frontend/widgets/pve_splash_screen.dart';
> +import 'utils/promox_colors.dart';
>  
>  void main() async {
>    WidgetsFlutterBinding.ensureInitialized();
> @@ -91,7 +92,7 @@ class MyApp extends StatelessWidget {
>            brightness: Brightness.light,
>            fontFamily: "Open Sans",
>            primarySwatch: Colors.blue,
> -          primaryColor: Color(0xFF00617F),
> +          primaryColor: ProxmoxColors.supportBlue,
>            primaryTextTheme: TextTheme(
>              headline6:
>                  TextStyle(fontFamily: "Open Sans", fontWeight: FontWeight.w700),
> diff --git a/lib/utils/promox_colors.dart b/lib/utils/promox_colors.dart
> new file mode 100644
> index 0000000..f45ef3d
> --- /dev/null
> +++ b/lib/utils/promox_colors.dart
> @@ -0,0 +1,10 @@
> +import 'package:flutter/material.dart';
> +
> +class ProxmoxColors {
> +  static final Color orange = Color(0xFFE57000);
> +  static final Color black = Color(0xFF000000);
> +  static final Color supportLightOrange = Color(0xFFFF9100);
> +  static final Color supportGrey = Color(0xFFABBABA);
> +  static final Color supportBlue = Color(0xFF00617F);
> +  static final Color supportDarkGrey = Color(0xFF464D4D);
> +}

With the exception of supportBlue (why support?) none of these colors are used why should we add them if they aren't used anywhere?

Black is definitely not a color we need to define.

> diff --git a/lib/widgets/pve_guest_overview_header.dart b/lib/widgets/pve_guest_overview_header.dart
> index c5bff16..8ed9d5d 100644
> --- a/lib/widgets/pve_guest_overview_header.dart
> +++ b/lib/widgets/pve_guest_overview_header.dart
> @@ -4,6 +4,7 @@ import 'package:built_collection/built_collection.dart';
>  import 'package:flutter/material.dart';
>  import 'package:font_awesome_flutter/font_awesome_flutter.dart';
>  import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
> +import 'package:pve_flutter_frontend/utils/promox_colors.dart';
>  import 'package:pve_flutter_frontend/utils/renderers.dart';
>  import 'package:pve_flutter_frontend/widgets/pve_guest_icon_widget.dart';
>  
> @@ -41,7 +42,7 @@ class PveGuestOverviewHeader extends StatelessWidget {
>        height: 250,
>        width: width,
>        decoration: BoxDecoration(
> -        color: Color(0xFF00617F),
> +        color: ProxmoxColors.supportBlue,
>        ),
>        child: Stack(
>            fit: StackFit.expand,
> diff --git a/lib/widgets/pve_node_overview.dart b/lib/widgets/pve_node_overview.dart
> index e193193..f7c334b 100644
> --- a/lib/widgets/pve_node_overview.dart
> +++ b/lib/widgets/pve_node_overview.dart
> @@ -5,6 +5,7 @@ import 'package:pve_flutter_frontend/bloc/pve_node_overview_bloc.dart';
>  import 'package:pve_flutter_frontend/bloc/pve_task_log_bloc.dart';
>  import 'package:pve_flutter_frontend/states/pve_node_overview_state.dart';
>  import 'package:pve_flutter_frontend/states/pve_task_log_state.dart';
> +import 'package:pve_flutter_frontend/utils/promox_colors.dart';
>  import 'package:pve_flutter_frontend/utils/renderers.dart';
>  import 'package:pve_flutter_frontend/utils/utils.dart';
>  import 'package:pve_flutter_frontend/widgets/proxmox_capacity_indicator.dart';
> @@ -46,7 +47,7 @@ class PveNodeOverview extends StatelessWidget {
>                  overflow: TextOverflow.ellipsis,
>                ),
>              ),
> -            backgroundColor: Color(0xFF00617F),
> +            backgroundColor: ProxmoxColors.supportBlue,
>              body: SingleChildScrollView(
>                child: Column(
>                  children: <Widget>[
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel