public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text
Date: Tue, 30 Sep 2025 18:07:56 +0200	[thread overview]
Message-ID: <438f8008-bc74-4112-b05c-19ffa4e9a55a@proxmox.com> (raw)
In-Reply-To: <20250916125746.164814-1-m.koeppl@proxmox.com>

ping, still applies

On 9/16/25 2:57 PM, Michael Köppl wrote:
> Without this change, only the value of the type variable would be used
> as the task description for task types without an entry in the
> task_desc_table.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/Utils.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/Utils.js b/src/Utils.js
> index a0c6ca5..236390a 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -770,7 +770,7 @@ Ext.define('Proxmox.Utils', {
>              if (!farray) {
>                  text = type;
>                  if (id) {
> -                    type += ' ' + id;
> +                    text += ' ' + id;
>                  }
>                  return text;
>              } else if (Ext.isFunction(farray)) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      reply	other threads:[~2025-09-30 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 12:57 Michael Köppl
2025-09-30 16:07 ` Michael Köppl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438f8008-bc74-4112-b05c-19ffa4e9a55a@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal