public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>,
	pve-devel@pve.proxmox.com
Subject: [pve-devel] applied: [PATCH v4 common 1/3] daemon: listen also on ipv6
Date: Wed, 21 Apr 2021 18:16:41 +0200	[thread overview]
Message-ID: <434d2f5d-f6ed-6033-3f00-6c488510e86d@proxmox.com> (raw)
In-Reply-To: <20210324132036.592880-1-o.bektas@proxmox.com>

On 24.03.21 14:20, Oguz Bektas wrote:
> see [0]
> when we set 'Domain' to PF_INET6 by default, it will prefer IPv6. since
> we don't set 'V6Only' it will also listen on IPv4 interfaces.
> 
> 'Family' parameter isn't needed anymore.
> 
> this change depends on the changes in pve-manager and pve-http-server to
> work correctly.
> 
> [0]:
> https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v3->v4:
> * remove $family parameter
> 
>  src/PVE/Daemon.pm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!

but please do not send new patch versions to a sub-thread with in-reply-to, that's
in general just easier to overlook and thus get lost and harder to piece together
a series on applying.

General note: the pveproxy needs to be restarted, not reloaded, for this change
to be applied. Was a bit thrown off by that, as installing this and the updated
pve-manager package only triggered a reload and the process kept listening on the
"old" local address (0.0.0.0:8006) vs. the always-correct™ *:8006 one




  reply	other threads:[~2021-04-21 16:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 14:00 [pve-devel] [PATCH v3 http-server common manager 0/3] fix #2997: pveproxy LISTEN address Oguz Bektas
2021-03-22 14:00 ` [pve-devel] [PATCH v3 common 1/3] daemon: listen also on ipv6 Oguz Bektas
2021-03-24  8:37   ` Fabian Ebner
2021-03-24 10:38     ` Oguz Bektas
2021-03-24 11:00       ` Fabian Ebner
2021-03-24 12:59         ` [pve-devel] [PATCH pmg-api] pmgproxy: allow setting LISTEN_IP parameter Oguz Bektas
2021-03-24 13:20         ` [pve-devel] [PATCH v4 common 1/3] daemon: listen also on ipv6 Oguz Bektas
2021-04-21 16:16           ` Thomas Lamprecht [this message]
2021-03-22 14:00 ` [pve-devel] [PATCH v3 manager 2/3] proxy: allow setting LISTEN_IP for pveproxy and spiceproxy Oguz Bektas
2021-03-24  8:37   ` Fabian Ebner
2021-03-24 10:03     ` Oguz Bektas
2021-03-22 14:00 ` [pve-devel] [PATCH v3 http-server 3/3] utils: add LISTEN_IP option in /etc/default/pveproxy Oguz Bektas
2021-03-23 13:30   ` Dylan Whyte
2021-04-21 15:44   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434d2f5d-f6ed-6033-3f00-6c488510e86d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=pve-devel@pve.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal