From: Filip Schauer <f.schauer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container v4 4/4] implement device hotplug
Date: Wed, 30 Jul 2025 14:12:53 +0200 [thread overview]
Message-ID: <432a2809-1c7c-487d-9ca0-a96974f55704@proxmox.com> (raw)
In-Reply-To: <c1cecf40-2544-4d57-af7f-a51db2de4680@proxmox.com>
On 30/07/2025 12:59, Thomas Lamprecht wrote:
> Below would do well with a comment, and actually I'm not really sure it's needed,
> currently the print_device called in apply_pending_device_passthrough is just
> printing the property string per the format, which we just parsed before,
> so this should be 1:1 the same before after here? Unlike for mpX mountpoints,
> where the formatted string might change. Or is this just for future preparation
> for more complex handling/devices?
>
> In anyway, can be fine as is now, it doesn't really hurt either, it's just
> a little bit confusing and might be unnecessary, so maybe take another look
> at this or provide some rationale.
This is indeed unnecessary. I will send a patch to simplify this.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-30 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 12:47 [pve-devel] [PATCH container v4 0/4] " Filip Schauer
2025-07-28 12:47 ` [pve-devel] [PATCH container v4 1/4] extract apparmor profile & namespace switch to a helper Filip Schauer
2025-07-28 12:47 ` [pve-devel] [PATCH container v4 2/4] extract passthrough device node creation " Filip Schauer
2025-07-28 12:47 ` [pve-devel] [PATCH container v4 3/4] config: support printing a device Filip Schauer
2025-07-28 12:47 ` [pve-devel] [PATCH container v4 4/4] implement device hotplug Filip Schauer
2025-07-30 10:59 ` Thomas Lamprecht
2025-07-30 12:12 ` Filip Schauer [this message]
2025-07-30 11:40 ` [pve-devel] applied-series: [PATCH container v4 0/4] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432a2809-1c7c-487d-9ca0-a96974f55704@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox