From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode
Date: Tue, 9 Dec 2025 08:59:59 +0100 [thread overview]
Message-ID: <42197a46-ac7c-4adf-99a4-628cff5c0fb7@proxmox.com> (raw)
In-Reply-To: <176494884271.155100.16563011649636460356.b4-ty@proxmox.com>
On 12/5/25 4:34 PM, Thomas Lamprecht wrote:
> On Fri, 05 Dec 2025 15:34:45 +0100, Dominik Csapak wrote:
>> For some reason, using a space separated list of classes in `itemCls`
>> breaks the extjs debug mode. This is seemingly allowed everywhere else,
>> so to fix it, simply apply the classes directly to the children
>> with 'default'.
>>
>>
>
> Applied, thanks!
>
> [1/1] RRDTypeSelector: fix extjs debug mode
> commit: 54a2e4173c47e7891af9cbbbdbf4f976a924fc7c
thanks for fixing the type, but sadly it was not complete, see my
current patch that fixes it:
https://lore.proxmox.com/pve-devel/20251209074037.114475-1-d.csapak@proxmox.com/T/#u
to explain how the typo slipped in:
usually i stash my changes when testing different things, but in this
case i thought the three lines are easy enough to do it fresh,
but obviously i didn't retest with the patch i sent
so, sorry for the noise and additional work this caused
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-12-09 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 14:34 [pve-devel] " Dominik Csapak
2025-12-05 15:15 ` Max R. Carrara
2025-12-05 15:16 ` Thomas Lamprecht
2025-12-05 15:34 ` [pve-devel] applied: " Thomas Lamprecht
2025-12-09 7:59 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42197a46-ac7c-4adf-99a4-628cff5c0fb7@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox