From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] pve7to8: detect kernel 6.8.x as a valid running kernel
Date: Tue, 28 May 2024 13:00:21 +0200 [thread overview]
Message-ID: <41da1232-69af-4a7c-b6f3-83b26f49f6c1@proxmox.com> (raw)
In-Reply-To: <30a9a48d-0fe9-42d1-827b-3fb79d83744e@proxmox.com>
Am 17.05.24 um 14:22 schrieb Dominik Csapak:
> On 5/17/24 10:31, Fiona Ebner wrote:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/145723/post-664612
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> PVE/CLI/pve7to8.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
>> index b34c8362..8443f1fb 100644
>> --- a/PVE/CLI/pve7to8.pm
>> +++ b/PVE/CLI/pve7to8.pm
>> @@ -204,7 +204,7 @@ sub check_pve_packages {
>> }
>> # FIXME: better differentiate between 6.2 from bullseye or
>> bookworm
>> - my ($krunning, $kinstalled) =
>> (qr/6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|5)[^~]*$/, 'proxmox-kernel-6.2');
>> + my ($krunning, $kinstalled) =
>> (qr/6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|5|8)[^~]*$/,
>> 'proxmox-kernel-6.2');
>> if (!$upgraded) {
>> # we got a few that avoided 5.15 in cluster with mixed CPUs,
>> so allow older too
>> ($krunning, $kinstalled) = (qr/(?:5\.(?:13|15)|6\.2)/,
>> 'pve-kernel-5.15');
>
> wouldn't it be more future proof to just check if the kernel is a -pve
> one and the version is higher (or equal) than what was shipped in pve7 ?
>
> i guess the same thing will happen for pve8to9 sooner or later...
>
Sent a v2 with that approach:
https://lists.proxmox.com/pipermail/pve-devel/2024-May/064005.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-28 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 8:31 Fiona Ebner
2024-05-17 12:22 ` Dominik Csapak
2024-05-28 11:00 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41da1232-69af-4a7c-b6f3-83b26f49f6c1@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox